This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3484

New version got released for 64 bit only. Should I leave it as it is after a force-push or should I just drop 32 bit build?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3617

How do you test this package? Getting no error but no output either when trying to run a test.

$ result/bin/furmark --p1080
MESA-INTEL: warning: cannot initialize blitter engine

How do you test this package? Getting no error but no output either when trying to run a test.

$ result/bin/furmark --p1080
MESA-INTEL: warning: cannot initialize blitter engine

You want to run the gui, but if you want to test cli
furmark --demo furmark-gl
furmark --demo furmark-vk

tysm, I'll fix everything later today, I'm at work rn

I left i686-linux as leaving it isn't really problematic imo, also I added aarch64 which was added in 2.3.0.0. Could you please check again?

I don't have a native aarch64 device to test on, though I tried with binfmt and it segfaults at runtime

non-existent Revision: Could not determine Pi model
zsh: segmentation fault (core dumped)  result/bin/FurMark_GUI

Do you have such a device to test this on to confirm that it works?

I don't.
Also I didn't have much success running even cli apps using binfmt beforr. I wonder if that segfault is caused by emulation or if furmark runs only on rpi 😐

Seems to fail with the same error, even on my Raspberry Pi 4

Nevermind, running it directly as furmark seems to work.

The style of handling unsupported platforms in this PR doesn't go well with the current release-checks: https://hydra.nixos.org/build/260730842/nixlog/1/tail
and consequently the nixpkgs-unstable channel is blocked (and maybe more of them that haven't tried yet).

Not sure I understand - meta.platforms only lists linux, why is darwin being checked? And why is CI not catching this?

CI doesn't exactly replicate all checks. I'm not saying it's this PR's fault really – maybe it would be better to relax the checks. I'm not sure why you'd need a valid version if you don't support that platform.

I've created a revert PR at #313741, let me know if that suffices for now.

I'm not sure why you'd need a valid version if you don't support that platform.

huh? you mean it tries to run passthru.tests.version on darwin?

No. furmark.version

No, they're saying it's checking the version attribute for even unsupported platforms. I guess the other option would be something like versions.${system} or throw "Unsupported platform" but I'm not sure how to run the release checks hence went with the simple revert PR.

The checks can be run e.g. by nix build -f pkgs/top-level/release.nix release-checks but beware that it's expensive. It eats lots of RAM, in particular.

alr, so something like this should be enough?

should we do it in both version and src?

I'll be leaving work in 30 mins if this can wait, unless if someone wants to PR it right now, or just merge the revert I guess